RFR: 2373: Support repo-<project> style fix versions [v2]
Erik Joelsson
erikj at openjdk.org
Wed Sep 18 14:07:21 UTC 2024
On Tue, 17 Sep 2024 23:46:46 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment
>
> jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 82:
>
>> 80: // Check for team/project special version
>> 81: if (finalComponents.isEmpty()) {
>> 82: var projectRepoPattern = Pattern.compile("repo-([a-z0-9]*)");
>
> For consistency with the surrounding code, would it be better to define this pattern as a static variable?
I thought about that and didn't bother, but you are right.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1686#discussion_r1765120629
More information about the skara-dev
mailing list