RFR: 2479: PR marked as ready with jcheck error [v2]

[Erik Joelsson]

On Thu, 17 Apr 2025 18:27:07 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, when determining if a PR is ready, if the PR doesn't require a review, it also ignores all jcheck failures. Instead, only reviewers check should be ignored in this case.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 75:

> 73:     }
> 74: 
> 75:     List<String> errorFailedCheckMessagesWithoutReviewersCheck() {

This is a mouthful. I was thinking something like `boolean tooFewReviewers()`.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2049541313