RFR: 2479: PR marked as ready with jcheck error [v2]
Zhao Song
zsong at openjdk.org
Thu Apr 17 20:02:23 UTC 2025
On Thu, 17 Apr 2025 19:40:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comment
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 75:
>
>> 73: }
>> 74:
>> 75: List<String> errorFailedCheckMessagesWithoutReviewersCheck() {
>
> This is a mouthful. I was thinking something like `boolean tooFewReviewers()`.
Do you mean that `tooFewReviewers()` should return true when there is only ReviewersCheck Failure?
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2049561152
More information about the skara-dev
mailing list