RFR: 2479: PR marked as ready with jcheck error [v2]

[Zhao Song]

On Thu, 17 Apr 2025 20:00:18 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 75:
>> 
>>> 73:     }
>>> 74: 
>>> 75:     List<String> errorFailedCheckMessagesWithoutReviewersCheck() {
>> 
>> This is a mouthful. I was thinking something like `boolean tooFewReviewers()`.
>
> Do you mean that `tooFewReviewers()` should return true when there is only ReviewersCheck Failure?

Or does `tooFewReviewers()` return true when there is a ReviewersCheck Failure in the list?
If so, the logic should be  like this
`            var readyToPostApprovalNeededComment = readyForReview &&
                    ((!reviewNeeded && visitor.errorFailedChecksMessages().size() == 1 && visitor.tooFewReviewers()) ||
                            visitor.errorFailedChecksMessages().isEmpty()) &&
                    integrationBlockers.isEmpty() &&
                    !statusMessage.contains(TEMPORARY_ISSUE_FAILURE_MARKER);`

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2049573361