RFR: 2479: PR marked as ready with jcheck error [v4]

[Erik Joelsson]

On Mon, 21 Apr 2025 22:47:39 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, when determining if a PR is ready, if the PR doesn't require a review, it also ignores all jcheck failures. Instead, only reviewers check should be ignored in this case.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty commit

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1473:

> 1471: 
> 1472:             var readyToPostApprovalNeededComment = readyForReview &&
> 1473:                     visitor.hasErrors(reviewNeeded) &&

Shouldn't this be negated?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2056320641