RFR: 2479: PR marked as ready with jcheck error [v4]

[Zhao Song]

On Wed, 23 Apr 2025 15:30:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Empty commit
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1473:
> 
>> 1471: 
>> 1472:             var readyToPostApprovalNeededComment = readyForReview &&
>> 1473:                     visitor.hasErrors(reviewNeeded) &&
> 
> Shouldn't this be negated?

Thanks for catching it. You are right. I remember I added "!" but Somehow it disappeared...

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1714#discussion_r2056417466