RFR: 2480: Add new PR command /ping [v2]
Zhao Song
zsong at openjdk.org
Wed Apr 30 22:18:12 UTC 2025
> This PR is trying to add a new pull request command "ping".
>
> The reported wants to have a pull request command that can refresh the timeouts of the pr so that the pr wouldn't be closed by pullRequestPrunerBot.
>
> The reported proposed to name the command "keep-alive" with alias "/ping", however, we store command names in an Enum class, so "keep-alive" is invalid. I think we just use "ping" as the command name.
>
> Besides, I would like to let the command trigger a force update of the pr. Currently, there are some cases that skara bot won't re-evaluate the pr automatically and users need to do something to poke it(like editing the pr title), so I think it's better to have a pull request command to trigger the update.
Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/PingCommand.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/PingCommand.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1716/files
- new: https://git.openjdk.org/skara/pull/1716/files/acff8cdf..2239c18f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1716&range=01
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1716&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/skara/pull/1716.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1716/head:pull/1716
PR: https://git.openjdk.org/skara/pull/1716
More information about the skara-dev
mailing list