RFR: 2480: Add new PR command /ping [v2]
Zhao Song
zsong at openjdk.org
Wed Apr 30 22:20:09 UTC 2025
On Wed, 30 Apr 2025 22:12:55 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PingCommand.java line 57:
>>
>>> 55: public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, ScratchArea scratchArea, CommandInvocation command, List<Comment> allComments, PrintWriter reply) {
>>> 56: if (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) {
>>> 57: reply.println("Only the author of the pull request or [Reviewers](https://openjdk.org/bylaws#reviewer) are allowed to change the number of required reviewers.");
>>
>> Copy-paste error?
>>
>> I think we can allow any census member to use this command.
>
> No, I did it intentionally. I think this will trigger the re-evaluate of the pr, so it will consume skara resources.
I think you're right, there's no need to add any restrictions to this command. If someone wanted to make a flood attack on Skara, they could just keep editing the pull request title.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1716#discussion_r2069554897
More information about the skara-dev
mailing list