RFR: 2557: Set resolution to Fixed when resolving Jira issues

Erik Joelsson erikj at openjdk.org
Thu Aug 7 21:34:57 UTC 2025


On Thu, 7 Aug 2025 21:18:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to let Skara  bot  explicitly set resolution to "Fixed" when resolving Jira issues.

I think this change warrants a new manual integration test.

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 246:

> 244:                 .put("transition", JSON.object()
> 245:                         .put("id", id));
> 246:         if (state.equals("RESOLVED")) {

This method is called with `"Resolved"` not `"RESOLVED"`. To avoid relying on string comparisons here, could we make all the calls to this method use constants, or perhaps even an internal enum?

-------------

PR Review: https://git.openjdk.org/skara/pull/1730#pullrequestreview-3098792848
PR Review Comment: https://git.openjdk.org/skara/pull/1730#discussion_r2261449607


More information about the skara-dev mailing list