RFR: 2454: Skara mistakenly marked a non-clean backport as clean [v2]
Zhao Song
zsong at openjdk.org
Mon Mar 10 16:35:42 UTC 2025
On Mon, 10 Mar 2025 14:08:16 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rename method
>
> forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 837:
>
>> 835: }
>> 836: return diffLimited.get();
>> 837: }
>
> I think it would be better to add a boolean field `complete` to `Diff`, instead of having this be a property of a PullRequest. Then we avoid this awkward requirement for ordering calls on PullRequest.
Yes, this sounds much better. Thank you for the suggestion.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1708#discussion_r1987649282
More information about the skara-dev
mailing list