RFR: 2454: Skara mistakenly marked a non-clean backport as clean [v2]

Zhao Song zsong at openjdk.org
Wed Mar 12 22:42:05 UTC 2025


On Mon, 10 Mar 2025 14:01:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename method
>
> forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 48:
> 
>> 46: 
>> 47:     private List<Label> labels = null;
>> 48:     private Optional<Boolean> diffLimited = Optional.empty();
> 
> We should not use `Optional` in fields. If we need a tri-state for this boolean, then it's better to use `Boolean` and check for null.

Will fix it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1708#discussion_r1987653844


More information about the skara-dev mailing list