RFR: 2466: Cut down list of other commits from 10 to 3
Erik Joelsson
erikj at openjdk.org
Wed Mar 26 12:46:43 UTC 2025
On Wed, 26 Mar 2025 10:19:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 52:
>>
>>> 50: class CheckRun {
>>> 51: public static final String MSG_EMPTY_BODY = "The pull request body must not be empty.";
>>> 52: private static final int COMMIT_LIST_LIMIT = 3;
>>
>> I think we should share this constant between these two classes.
>
> That sounds good. Where should I place it? I did not want to introduce a dependency between the two classes since I did not know how they relate.
It doesn't matter that much, but `CheckRun` uses `CheckablePullRequest` so maybe a bit better to put it in the latter. It's just a constant and these classes are part of the same package.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1710#discussion_r2014065498
More information about the skara-dev
mailing list