RFR: 2509: Don't display duplicate jcheck warnings when the checks are displayed in Progress [v2]

[Erik Joelsson]

On Wed, 28 May 2025 23:00:21 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In the pull request body, we have a 'Progress' part which will display the progresses of some jchecks, however, if the jchecks in the progress fail as warning, it will also be displayed in 'Warning' part. It will confuse the users.
>> 
>> The other issue is that, right now, if whitespace check failed as warning, then users are not able to know where are the whitespace issues.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update
>  - update

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 422:

> 420:                 for (var annotation : visitor.getAnnotations()) {
> 421:                     checkBuilder.annotation(annotation);
> 422:                 }

I don't think we can assume that all `annotations` are whitespace warnings in this method. I don't think we need a summary text here, but it's hard to tell from just reading the code. The "Optional" title instead of "Required" and the list of annotations should be enough I think.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 89:

> 87:     }
> 88: 
> 89:     List<String> hiddenWarningMessages(){

Suggestion:

    List<String> hiddenWarningMessages() {

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1719#discussion_r2114322948
PR Review Comment: https://git.openjdk.org/skara/pull/1719#discussion_r2114327472