RFR: 2509: Don't display duplicate jcheck warnings when the checks are displayed in Progress [v2]

[Zhao Song]

On Thu, 29 May 2025 16:30:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update
>>  - update
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 422:
> 
>> 420:                 for (var annotation : visitor.getAnnotations()) {
>> 421:                     checkBuilder.annotation(annotation);
>> 422:                 }
> 
> I don't think we can assume that all `annotations` are whitespace warnings in this method. I don't think we need a summary text here, but it's hard to tell from just reading the code. The "Optional" title instead of "Required" and the list of annotations should be enough I think.

Yes, for now, only whitespace check would generate annotations, but later, we may have other checks can generate annotations. But without a summary, GitHubPullRequest won't add the annotations to check. see: https://github.com/openjdk/skara/blob/131e80e440eacb6434544ec9d93f385601cce996/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java#L480

So we need to put something else in the summary.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1719#discussion_r2114363268