RFR: 2591: Improve auto labeler

[Erik Joelsson]

On Tue, 23 Sep 2025 17:57:16 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java line 160:
>> 
>>> 158:                             newLabels.add(label);
>>> 159:                         }
>>> 160:                     }
>> 
>> I think this check needs to be applied on the initial run of the auto labeler as well. The user may have manually added labels already (which previously would disable the auto labeler), but now since we run it anyway, I think it needs to check for existing group labels.
>> 
>> I also think we are missing the case when an existing label would pair up with a new label to match a group. Then the new label should be upgraded to the group.
>
> Yes, you're right. I need to add the check for initial run as well.
> 
>> I also think we are missing the case when an existing label would pair up with a new label to match a group. Then the new label should be upgraded to the group.
> In this case, do you mean we just add the group label and keep the old labels?

Yes, I'm referring to 2 in the examples.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1741#discussion_r2373094429