<Sound Dev> [9] Review Request: 8178971 Uncommon formatting and typos in java.desktop module

Sergey Bylokhov sergey.bylokhov at oracle.com
Wed Apr 19 17:29:06 UTC 2017


Hello,
Please review the fix for jdk9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8178971
Webrev can be found at: http://cr.openjdk.java.net/~serb/8178971/webrev.00
Webrev which ignores spaces: http://cr.openjdk.java.net/~serb/8178971/webrev_no_space.00 <http://cr.openjdk.java.net/~serb/8178971/webrev_no_space.00>

 - Two typos were fixed in AbstractMultiResolutionImage.java(incorrect tag) and java/awt/package-info.java("con tainer"instead of "container")
 - The code formatting was fixed in "module-info.java", it seems that different iterations of modules refresh patches used a different line wrapping and code shifting(4 or 5 spaces)
 - In java sound there are a few places where we replace tabs to spaces and this caused strange alignment of constants


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20170419/5711b14c/attachment.html>


More information about the sound-dev mailing list