<Sound Dev> [9] Review Request: 8178971 Uncommon formatting and typos in java.desktop module

Phil Race philip.race at oracle.com
Wed Apr 19 17:00:08 UTC 2017


+1

-phil.

On 04/19/2017 10:29 AM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8178971
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8178971/webrev.00 
> <http://cr.openjdk.java.net/%7Eserb/8178971/webrev.00>
> Webrev which ignores spaces: 
> http://cr.openjdk.java.net/~serb/8178971/webrev_no_space.00 
> <http://cr.openjdk.java.net/%7Eserb/8178971/webrev_no_space.00>
>
>  - Two typos were fixed in AbstractMultiResolutionImage.java(incorrect 
> tag) and java/awt/package-info.java("con tainer"instead of "container")
>  - The code formatting was fixed in "module-info.java", it seems that 
> different iterations of modules refresh patches used a different line 
> wrapping and code shifting(4 or 5 spaces)
>  - In java sound there are a few places where we replace tabs to 
> spaces and this caused strange alignment of constants
>
>



More information about the sound-dev mailing list