<Swing Dev> [PATCH] 6179357-related: warnings removal
Pavel Porvatov
Pavel.Porvatov at Sun.COM
Wed Jun 18 16:18:28 UTC 2008
Hi Florian,
I'm working on your patches and now completed about 30%. There are
really many changes in your fix and I made changes in your changes, so
it's not very fast...
Regards, Pavel.
> Hi Pavel,
>
> I just wanted to ask what the status of my patches is. I would like to
> continue to provide patches once those could be integrated.
>
> Thanks.
> -Florian
>
> Am Mittwoch, 14. Mai 2008 schrieb Pavel Porvatov:
>> Hi Florian,
>>
>> Great! I'll start work on it shortly.
>>
>> Thanks, Pavel.
>>
>>> Hi Pavel,
>>>
>>> it took a little longer than I thought, but now I've updated my patches
>>> to base on http://hg.openjdk.java.net/jdk7/swing/jdk and removed all the
>>> tabs.
>>>
>>> Unfortunatly it wasn't easily possible to port all patches. So I send
>>> here the big part and after integration I will try to remove some of the
>>> other warnings again before I start with adding generics to the Swing
>>> framework.
>>>
>>> When compiling with
>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>> this patch reduces the number of reported warnings from 1263 to 240.
>>>
>>> Again, I tried only to change things related to the warnings and not to
>>> change any public or protected APIs in public or protected classes in
>>> this patch.
>>>
>>> At many places I tried to add type parameters as meaningful as possible,
>>> but with some cases I just used Object, if a more meaningful type
>>> parameter was not so trivial. You might want to refactor this if needed.
>>> (Though everything should work as it is.)
>>>
>>> -Florian
>>>
>>> Am Dienstag, 29. April 2008 schrieb Florian Brunner:
>>>> Hi Pavel,
>>>>
>>>>> Send me all remaining fixes at once. I changed my opinion because
>>>>> 1. I don't want to produce a lot of CRs for every part of fix
>>>>> 2. I'm going to do a small correction (if needed of course) in your
>>>>> fix myself. It'll save a lot of our time
>>>> Ok, great, I will do that as soon as I find some spare time (probably
>>>> during the coming long week-end).
>>>>
>>>> -Florian
>
>
More information about the swing-dev
mailing list