<Swing Dev> [7] Review request for 6994562: Swing classes (both JTextArea and JTextField) don't support caret width tuning

Artem Ananiev artem.ananiev at oracle.com
Mon Jun 25 15:17:22 UTC 2012


On 6/25/2012 3:13 PM, Vladislav Karnaukhov wrote:
> Hello Artem,
>
> the property's change is tracked by native
> AwtDesktopProperties::getWindowsParameters() method, which is called
> from Java WDesktopProperties' call chain windowsSettingsChange ->
> updatePropertires -> getProperties. windowsSettingsChange method is
> called from native code when WM_SETTINGCHANGE message is received. Thus
> this call chain serves as "action listener", and caret width tuning will
> be tracked and handled along with any other possible Windows interface
> customization.

Ah, that makes sense. Thanks for this clarification. The fix looks fine 
then.

Artem

> Regards,
> - Vlad
>
> On 6/19/2012 7:17 PM, Artem Ananiev wrote:
>>
>> On 6/7/2012 8:53 PM, Vladislav Karnaukhov wrote:
>>> On 04.06.12 17:37, Artem Ananiev wrote:
>>>> Hi, Vladislav,
>>>>
>>>> does it survive system property changes, e.g. setting large fonts
>>>> windows theme?
>>> It does.
>>
>> Could you elaborate on this, please?
>>
>> What I see in the webrev, "win.caret.width" value is set only once,
>> when WDesktopProperties is initialized. Hence my question.
>>
>> Thanks,
>>
>> Artem
>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>> On 6/1/2012 6:26 PM, Vladislav Karnaukhov wrote:
>>>>> Hello,
>>>>>
>>>>> please review a fix for the following issue: 6994562 Swing classes
>>>>> (both
>>>>> JTextArea and JTextField) don't support caret width tuning
>>>>>
>>>>> http://monaco.sfbay.sun.com/detail.jsf?cr=6994562
>>>>>
>>>>> Please find webrev here:
>>>>> http://cr.openjdk.java.net/~alexp/6994562/webrev.00/
>>>>>
>>>>> This is a forward-port form JDK6. The fix introduces support for
>>>>> Windows
>>>>> Accessibility/Ease Of Access to Windows LAF.
>>>>>
>>>>> Regards,
>>>>> - Vlad
>>>
>
>



More information about the swing-dev mailing list