<Swing Dev> [8] Review request for CR 7124232: [TEST_BUG] [macosx] JSplitPane has wrong divider location

[Sergey Bylokhov]

Hi, Vera.
This version looks good. But before the push please cleanup this code:

57         Thread.sleep(1000);
58         Thread.sleep(2000);


On 19.09.2013 20:11, vera akulova wrote:
> Hello Sergey,
>
> please review updated version of the fix: 
> http://cr.openjdk.java.net/~kshefov/7124232/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ekshefov/7124232/webrev.01/>
>
> Thanks,
> Vera
>
> 13.09.2013 17:04, Sergey Bylokhov пишет:
>> Hi, Vera.
>>
>>  112         } catch(Exception e) {
>>  113             e.printStackTrace();
>>  114         }
>> I think, you should not catch exception here.
>>
>> On 13.09.2013 16:10, vera akulova wrote:
>>> Hello,
>>>
>>> Please review a fix for the issue:
>>> JDK-7124232 <https://bugs.openjdk.java.net/browse/JDK-7124232>: 
>>> [TEST_BUG] [macosx] JSplitPane has wrong divider location
>>>
>>> The webrev is http://cr.openjdk.java.net/~kshefov/7124232/webrev.00/
>>>
>>> The fix adds border for the JSplitPane.
>>>
>>> Test is moved from closed repo, diff with previous version of the 
>>> test: http://cr.openjdk.java.net/~kshefov/7124232/webrev.diff
>>>
>>> Thanks,
>>> Vera. 
>>
>>
>> -- 
>> Best regards, Sergey.
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20130919/1fa2de00/attachment.html>