<Swing Dev> [8] Review request for CR 7124232: [TEST_BUG] [macosx] JSplitPane has wrong divider location
Alexander Scherbatiy
alexandr.scherbatiy at oracle.com
Fri Sep 20 10:03:24 UTC 2013
The fix looks good for me.
Thanks,
Alexandr.
On 9/19/2013 8:11 PM, vera akulova wrote:
> Hello Sergey,
>
> please review updated version of the fix:
> http://cr.openjdk.java.net/~kshefov/7124232/webrev.01/
> <http://cr.openjdk.java.net/%7Ekshefov/7124232/webrev.01/>
>
> Thanks,
> Vera
>
> 13.09.2013 17:04, Sergey Bylokhov пишет:
>> Hi, Vera.
>>
>> 112 } catch(Exception e) {
>> 113 e.printStackTrace();
>> 114 }
>> I think, you should not catch exception here.
>>
>> On 13.09.2013 16:10, vera akulova wrote:
>>> Hello,
>>>
>>> Please review a fix for the issue:
>>> JDK-7124232 <https://bugs.openjdk.java.net/browse/JDK-7124232>:
>>> [TEST_BUG] [macosx] JSplitPane has wrong divider location
>>>
>>> The webrev is http://cr.openjdk.java.net/~kshefov/7124232/webrev.00/
>>>
>>> The fix adds border for the JSplitPane.
>>>
>>> Test is moved from closed repo, diff with previous version of the
>>> test: http://cr.openjdk.java.net/~kshefov/7124232/webrev.diff
>>>
>>> Thanks,
>>> Vera.
>>
>>
>> --
>> Best regards, Sergey.
>
More information about the swing-dev
mailing list