<Swing Dev> JDK9 Review Request for 8067660: JFileChooser create new folder fails silently

[Alexandr Scherbatiy]

27.11.2015 13:45, Rajeev Chamyal пишет:
> Hello Alexandr,
>
> I have updated the webrev as per review comments.
> http://cr.openjdk.java.net/~rchamyal/8067660/webrev.01/
>
> Attached image shows the error message.
     Thank you.

   I have only a comment about the test. It is defined only for Windows. 
Is it possible that the requested folder can't be created for example on 
Linux?

   Thanks,
   Alexandr.

>
> Regards,
> Rajeev Chamyal
>
> -----Original Message-----
> From: Alexander Scherbatiy
> Sent: 26 November 2015 16:18
> To: Rajeev Chamyal
> Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev at openjdk.java.net
> Subject: Re:<Swing Dev>  JDK9 Review Request for 8067660: JFileChooser create new folder fails silently
>
> On 11/25/2015 8:37 PM, Rajeev Chamyal wrote:
>> Hello Alexandr,
>>
>> Thanks for the review.
>>
>> I think other reason apart from access denied could be lack of space
>> on device/drive.
>>
>> The API documentation for File.mkdirs is not very clear on reasons
>> when the method will return false.
>>
>> Returns:
>>
>> trueif and only if the directory was created, along with all necessary
>> parent directories; falseotherwise.
>>
>> Please let me know if your inputs on this.
>>
>      In this case may be it is better to make the exception message more general to cover other failing reasons too?
>
>      Thanks,
>      Alexandr.
>> Regards,
>>
>> Rajeev Chamyal
>>
>> *From:*Alexandr Scherbatiy
>> *Sent:* 25 November 2015 21:30
>> *To:* Rajeev Chamyal
>> *Cc:* Prasanta Sadhukhan; Sergey Bylokhov; swing-dev at openjdk.java.net
>> *Subject:* Re:<Swing Dev>  JDK9 Review Request for 8067660:
>> JFileChooser create new folder fails silently
>>
>>
>> 19.11.2015 13:09, Rajeev Chamyal пишет:
>>
>>      Hello All,
>>
>>      Please review the following fix for Jdk9:
>>
>>
>>
>>      Bug:https://bugs.openjdk.java.net/browse/JDK-8067660
>>
>>      Webrev:http://cr.openjdk.java.net/~rchamyal/8067660/webrev.00/
>>      <http://cr.openjdk.java.net/%7Erchamyal/8067660/webrev.00/>
>>
>>      Issue: jFileChooser create new folder fails silently on windows
>>      without any exception.
>>
>>      Fix: Throwing an IOException from
>>      GenericFileSystemView::createNewFolder,WindowsFileSystemView::createNewFolder
>>      andUnixFileSystemView::createNewFolder if mkdirs call returns false.
>>
>>
>>      The exception message in the fix is: "Access denied". Are there
>> other reasons for which the File.mkdirs() can return false?
>>
>>      Thanks,
>>      Alexandr.
>>
>>      Regards,
>>
>>      Rajeev Chamyal
>>