<Swing Dev> RfR JDK-8134116, Add more comprehensive fix and regression test for JDK-8133897

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Oct 21 11:00:34 UTC 2015


On 10/20/2015 6:45 PM, Pete Brunet wrote:
> Please review this patch:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8134116/webrev.02/
>
> The issue raised/fixed in 8133897 and now resolved in a better fashion
> in this patch is caused by an override of the functionality of
> JTabbedPane such that its Page inner class title field is not kept up to
> date by the overriding code. When the Page title field is empty
> getTitleAt is now called so that the overridden getTitleAt will provide
> the title.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8134116

     The fix look goods to me.

    Do not forget to add the copyright header to the test.

   Thanks,
   Alexandr.
>
> Pete




More information about the swing-dev mailing list