<Swing Dev> RfR JDK-8134116, Add more comprehensive fix and regression test for JDK-8133897

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Oct 28 17:42:03 UTC 2015


Hi, Pete.
     I guess it will be better to don't use the title (especially 
parent.indexOfTab(title)) at all in the our code, except the situation 
when we should access the title(like in getAccessibleName()). All other 
cases should be rewritten to use parent.indexOfTabComponent(comp). For 
example your  "private String getTitle() {}" can be implemented like this:

    return getTitleAt(parent.indexOfTabComponent(comp));

On 20.10.15 18:45, Pete Brunet wrote:
> Please review this patch:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8134116/webrev.02/
>
> The issue raised/fixed in 8133897 and now resolved in a better fashion
> in this patch is caused by an override of the functionality of
> JTabbedPane such that its Page inner class title field is not kept up to
> date by the overriding code. When the Page title field is empty
> getTitleAt is now called so that the overridden getTitleAt will provide
> the title.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8134116
>
> Pete
>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list