<Swing Dev> [9] Review request for JDK-8159135 [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail

[Rajeev Chamyal]

Hello Alexandr,

 

Please review the updated webrev.

http://cr.openjdk.java.net/~rchamyal/8159135/webrev.01/

 

Regards,

Rajeev Chamyal

 

From: Alexandr Scherbatiy 
Sent: 10 June 2016 19:52
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [9] Review request for JDK-8159135 [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail

 


On 6/10/2016 12:36 PM, Rajeev Chamyal wrote:



Hello All,

 

Please review the following fix.

Bug : https://bugs.openjdk.java.net/browse/JDK-8159135 

Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8159135/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8159135/webrev.00/

 

Issue : MenuItemIconTest fails on windows 10.

Cause : In windows 10  menu bar color is white and test checks for red color only.

Fix: checking for other color values(green and blue) also.

    Is it possible to compare color using equals method like other objects:   Color.RED.equals(c)?

   Thanks,
   Alexandr.



 

Regards,

Rajeev Chamyal

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160612/b4a351ea/attachment.html>