<Swing Dev> [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Tue Jun 21 11:55:37 UTC 2016


On 6/14/2016 5:37 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-7020860
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/
>
> The methods mentioned in JIRA are not getters/setters according to 
> JavaBeans specs, nevertheless some of them got wrong javadocs. The 
> proposed fix improves the situation.

    I am not sure about the phrase "that is rendering each cell" in

  474      * Returns the current instance of the {@link 
TreeCellRenderer} that is
  475      * rendering each cell.

   Otherwise, the fix looks good to me.

   Thanks,
   Alexandr.


>
> --Semyon
>




More information about the swing-dev mailing list