<Swing Dev> [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

[Phil Race]

Hi,
I have some additional comments on this old review thread. Hopefully we 
can close it out soon
although it will need a CSR whatever ..

Since the implementation of ShellFolderManager filters out inaccessible 
files we
should document this somewhere.
I suggest either on the class or relevant methods saying something like
"Files or resources which are not accessible in the current security 
context
may be filtered out from the returned set".

The word "may" is key here ..

If we are sure that this is always the case then it would follow that 
SecurityException
does not need to be documented.
Consistency would suggest that then this policy would extend to the 
other methods
added in JDK 9 which declare that exception. So all or none.
Being a RuntimeException that is not checked I think we can compatibly 
remove those.

-phil.


On 10/24/2017 09:22 PM, Alexander Zvegintsev wrote:
>
> Hi Semyon,
>
> the fix looks good to me, but I found a minor typo in the test:
>
> testShortcatPanelFiles -> testShortcutPanelFiles
>
> no need for a new webrev
>
> Thanks,
> Alexander.
> On 04/10/2017 00:41, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10 (the changes involve AWT and Swing):
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8182041
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8182041/webrev.00/
>>
>> New API method was added letting to query shortcut panel entries for 
>> JFileChooser.
>>
>> --Semyon
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20171206/7a627536/attachment.html>