<Swing Dev> [10] JDK-6919529: NPE from MultiUIDefaults.getUIError

[Sergey Bylokhov]

Looks fine. 

----- shashidhara.veerabhadraiah at oracle.com wrote: 
> 
> 
> 

Hi Sergey, Thanks for letting me understand the difference between an error and an exception in Java and just for recording that understanding: 







I have modified the Webrev accordingly and here is the link to review: 

http://cr.openjdk.java.net/~pkbalakr/shashi/6919529/webrev_03/ 



Thanks and regards, 

Shashi 



-----Original Message----- 
> From: Sergey Bylokhov 
> Sent: Friday, July 7, 2017 4:11 AM 
> To: Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com> 
> Cc: swing-dev at openjdk.java.net; Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com> 
> Subject: Re: <Swing Dev> [10] JDK-6919529: NPE from MultiUIDefaults.getUIError 



> After we change the logic in the MultiUIDefaults.getUIError() method 

> by adding protection for the tables, the "else" path would be executed 

> rather than the "IF" path which was the earlier behavior. As can be 

> seen from this logic, the else part would call the super getUIError() 

> method and which throws the error to the user because the component UI 

> is null. 



Can you please recheck that the catch block in your test is executed. I am not sure about it. 



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170709/6a9778f7/attachment.html>