<Swing Dev> [10] Review Request: JDK-8190861: [TESTBUG] javax/swing/JWindow/ShapedAndTranslucentWindows/PerPixelTranslucentSwing.java is wrong

[Sergey Bylokhov]

Looks fine.

On 07/11/2017 08:54, Pankaj Bansal wrote:
> Hi,
> 
> Please review the fix for JDK 10.
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8190861
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~pbansal/8190861/webrev.00/
> 
> Issue:
> 
> The test passes when wrong color value is picked.
> 
> Fix:
> 
> The test checks that robot picked color is not equal to FG_COLOR color. 
> This is done to check transparency, so that the picked color is not same 
> as FG_COLOR color.  But this causes the test to pass even if the picked 
> value is wrong. The test should check the picked color with BG_COLOR 
> color.  As the color is picked from between top button and center 
> component, the picked color should be equal to the BG_COLOR.
> 
> Regards,
> 
> Pankaj Bansal
> 


-- 
Best regards, Sergey.