<Swing Dev> [10] Review Request: JDK-8190861: [TESTBUG] javax/swing/JWindow/ShapedAndTranslucentWindows/PerPixelTranslucentSwing.java is wrong

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Tue Nov 14 11:01:21 UTC 2017


+1

Regards
Prasanta
On 11/7/2017 10:24 PM, Pankaj Bansal wrote:
>
> Hi,
>
> Please review the fix for JDK 10.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8190861
>
> Webrev:
>
> http://cr.openjdk.java.net/~pbansal/8190861/webrev.00/ 
> <http://cr.openjdk.java.net/%7Epbansal/8190861/webrev.00/>
>
> Issue:
>
> The test passes when wrong color value is picked.
>
> Fix:
>
> The test checks that robot picked color is not equal to FG_COLOR 
> color. This is done to check transparency, so that the picked color is 
> not same as FG_COLOR color.  But this causes the test to pass even if 
> the picked value is wrong. The test should check the picked color with 
> BG_COLOR color.  As the color is picked from between top button and 
> center component, the picked color should be equal to the BG_COLOR.
>
> Regards,
>
> Pankaj Bansal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20171114/feb55290/attachment.html>


More information about the swing-dev mailing list