<Swing Dev> [11] [JDK-8074286] : Add getSelectedIndices() to ListSelectionModel

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Mar 9 01:17:25 UTC 2018


Hi, Pankaj.
The fix looks fine, please add @since tag for the new methods in CSR.

On 02/02/2018 09:06, Pankaj Bansal wrote:
> Hi All,
> 
> Please review a fix for the Enhancement. I will raise a CSR after 
> technical evaluation.
> 
> Enhancement:
> 
> https://bugs.openjdk.java.net/browse/JDK-8074286
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~pbansal/8074286/webrev.00/
> 
> The enhancement requests to add getSelectedIndices function to 
> ListSelectionModel Interface as same function with duplicate 
> implementation is being used in JList, JTable and DefaultTableColumnModel.
> 
> I have also added the getSelectedItemsCount function in 
> ListSelectionModel, as this is also being used at multiple places with 
> same implementation.
> 
> JList.getSelectedValues and JList.getSelectedValuesList are also 
> modified to use getSelectionIndices instead of replicating the same code.
> 
> Regards,
> 
> Pankaj Bansal
> 


-- 
Best regards, Sergey.



More information about the swing-dev mailing list