<Swing Dev> [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

[Philip Race]

Hi,

A couple of questions

-    [sRoles setObject:NSAccessibilityTableRole forKey:@"table"];
+    [sRoles setObject:NSAccessibilityGridRole forKey:@"table"];

1) Why was "Table" wrong ? And why is "Grid" right ?

2) What was the purpose of that anyway without the code to back it up like :

+    } else if ([javaRole isEqualToString:@"table"]) {
+        newChild = [TableAccessibility alloc];

3)
+            AccessibleTable table = ac.getAccessibleTable();

Could table ever be null here ?

-phil.

On 8/29/18, 3:03 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk12.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8133713
> Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00
>
> This fix provides the minimal support of accessibility(VoiceOver) for 
> JTable.
>
> The table will be represented as a grid. The user will get audio 
> information about:
>  - number of columns
>  - number of rows
>  - the selected cells
>  - the description of the whole table
>  - the text in the current cell
>
> The user will be able to interact with the table(select/deselect cells.)
>
> Example and fix limitations are provided in the bug:
> https://bugs.openjdk.java.net/browse/JDK-8133713?focusedCommentId=14207364&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14207364 
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20181002/9462e568/attachment.html>