<Swing Dev> [14] RFR JDK-8231084:Large performance regression in SwingMark TextArea in 14-b13

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Wed Oct 23 23:07:40 UTC 2019


Hi All,

Please review a rollback of the bug fix which caused large performance 
regression for TextArea.

JDK-8226513 removes the zero component size check to layout the root 
view when text component is updated by resetting the rootViewNeedsLayout 
flag, but it caused textarea performance regression as rootview 
initialization is triggered multiple times.

JDK-8226513 was a regression of JDK-8160246, which was again regression 
of JDK-8130892, which in turn was a regression of JDK-8001470
where view's preferred size is set only when text component's height or 
width is 0. This check is modified in subsequent fixes which caused more 
regressions.

Proposed fix for performance regression is to roll back to original 
issue and figure out why negative insets are obtained for 
JEditorPane.getPreferredSize()

Bug: https://bugs.openjdk.java.net/browse/JDK-8231084

webrev: http://cr.openjdk.java.net/~psadhukhan/8231084/webrev.0/

Changeset of 8001470 : 
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ff8622450b29

A new bug JDK-8232917 has been created to investigate a fix for the 
original issue JDK-8001470.

Regards
Prasanta




More information about the swing-dev mailing list