<Swing Dev> [14] RFR 8232605: [macos] There is no Tooltip message displayed when Ctrl+F1 is clicked.

[Dmitry Markov]

> On 24 Oct 2019, at 02:36, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> On 10/23/19 3:17 am, Dmitry Markov wrote:
>> I agree the generic documentation should be updated. I have opened https://bugs.openjdk.java.net/browse/JDK-8232880 <https://bugs.openjdk.java.net/browse/JDK-8232880> to track that.
> 
> Thanks.
> 
>> Also I would like to update this particular test, as well: http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/ <http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/>
> 
> I am not sure it is needed, such system shortcuts will cause issues in lots of other tests.

I understand your concerns and I will update generic documentation shortly. At the same time I do not see any problems if we duplicate the information from the generic docs in the test. What do you think?

Thanks,
Dmitry
> 
>> Thanks,
>> Dmitry
>>> On 22 Oct 2019, at 19:19, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com> <mailto:Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>>> wrote:
>>> 
>>> Hi, Dmitry.
>>> 
>>> I think it is better to describe this requirement in some generic documentation rather than single test.
>>> It is applicable to the manual and automatic tests.
>>> Probably it is time to add a new block related to client to open/doc/testing.md?
>>> 
>>> On 10/22/19 3:45 am, Dmitry Markov wrote:
>>>> Hi Sergey,
>>>> You are right, if the system reservation for “CTRL” + “F1” key sequence is disabled then the test works as expected. I have updated the test with some additional  instructions for this case:http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/ <http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/>
>>>> Can you take a look, please?
>>>> Thanks,
>>>> Dmitry
>>>>> On 21 Oct 2019, at 20:11, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com> <mailto:Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>><mailto:Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>>> wrote:
>>>>> 
>>>>> Hi, Dmitry.
>>>>> 
>>>>> I just tried this test on macOS and it works fine, can you please clarify by what
>>>>> operation this shortcut is reserved?
>>>>> If it is reserved by operation from System Preferences -> Keyboard -> Shortcuts,
>>>>> then the right thing to do is to disable all system shortcuts. It is applicable to
>>>>> all test systems win/lin/mac/etc.
>>>>> 
>>>>> On 10/21/19 2:51 am, Dmitry Markov wrote:
>>>>>> The key sequence “CTRL” + “F1”, which is used to show/hide tooltip message in Java GUI applications, is reserved by the system on OSX platform. The following test, which uses this key binding, should NOT be executed on Mac to avoid any confusion:
>>>>>> open/test/jdk/javax/swing/ToolTipManager/JMenuItemToolTipKeyBindingsTest/JMenuItemToolTipKeyBindingsTest.java
>>>>> 
>>>>> 
>>>>> --
>>>>> Best regards, Sergey.
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20191024/9cc834b5/attachment.html>