<Swing Dev> RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

Phil Race prr at openjdk.java.net
Thu Dec 17 18:05:59 UTC 2020


On Thu, 17 Dec 2020 13:02:12 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> @prrace Did you approve the 1st version of the fix [https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00]
>> or the current (4th) version? 
>> If 1st, is there any way to integrate the 1st version without updating the PR?
>
>>  If 1st, is there any way to integrate the 1st version without updating the PR?
> 
> No, this is not possible. If you need to integrate an earlier version, you will need to revert those changes in your local branch and push them.

I wouldn't know how to approve an earlier version. SFAIK I approved the current version.
One thing here though is that I think you should WITHDRAW this PR and re-submit for JDK 16.
I don't think we want to have to wait until JDK 17 to be able to read tabs on macOS 11.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1182


More information about the swing-dev mailing list