<Swing Dev> RFR: 8249588 : libwindowsaccessbridge issues on 64bit Windows

[Baesken, Matthias]

Hi  Ambarish, thanks for verifying .

May I add you + Phil  as reviewers ?


Best regards, Matthias

From: Ambarish Rapte <ambarish.rapte at oracle.com>
Sent: Samstag, 18. Juli 2020 16:42
To: Baesken, Matthias <matthias.baesken at sap.com>; Philip Race <philip.race at oracle.com>
Cc: swing-dev at openjdk.java.net
Subject: RE: <Swing Dev> RFR: 8249588 : libwindowsaccessbridge issues on 64bit Windows

Hi Phil and Matthias,

I verified that JAWS starts normally with the updated libwindowsaccessbridge and reads the components as expected. Also, verified that the tools jaccessinspector and jaccesswalker start and behave same before and after this change.

Regards,
Ambarish

From: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Sent: Friday, July 17, 2020 11:55 AM
To: Philip Race <philip.race at oracle.com<mailto:philip.race at oracle.com>>
Cc: swing-dev at openjdk.java.net<mailto:swing-dev at openjdk.java.net>
Subject: Re: <Swing Dev> RFR: 8249588 : libwindowsaccessbridge issues on 64bit Windows

Hi Phil, thanks for asking your colleagues to verify it .

Best regards, Matthias

From: Philip Race <philip.race at oracle.com<mailto:philip.race at oracle.com>>
Sent: Donnerstag, 16. Juli 2020 19:27
To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Cc: swing-dev at openjdk.java.net<mailto:swing-dev at openjdk.java.net>
Subject: Re: RFR: 8249588 : libwindowsaccessbridge issues on 64bit Windows

This looks OK but I've asked folks with access to JAWS to apply and verify it.

We'll wait for those results.

And when we are done, please push to jdk/client.

-phil.

On 7/16/20, 1:02 AM, Baesken, Matthias wrote:
Hello, looks like   libwindowsaccessbridge  has some issues in native coding on 64bit Windows , probably it was developed with 32bit in mind
And still misses a few adjustments.

WinAccessBridge .h/cpp  contains

    BOOL CALLBACK AccessBridgeDialogProc(HWND hDlg, UINT message,
                                         UINT wParam, LONG lParam);

and

    theDialogWindow = CreateDialog(windowsInstance,
                                   "ACCESSBRIDGESTATUSWINDOW", NULL,
                                   (DLGPROC) AccessBridgeDialogProc);

But  DLGPROC   has parameters  (  https://docs.microsoft.com/en-us/windows/win32/api/winuser/nc-winuser-dlgproc  )

  HWND Arg1,
  UINT Arg2,
  WPARAM Arg3,
  LPARAM Arg4

So probably the 3rd and 4th  params should be  ... WPARAM wParam,  LPARAM  lParam   .
One internal user  claimed to have crashes because of this  type mismatch .


Additionally I found some unused declarations  in WinAccessBridge.h  probably we could delete them .

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8249588

http://cr.openjdk.java.net/~mbaesken/webrevs/8249588.0/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8249588.0/>

Thanks, Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200720/7ece472a/attachment-0001.htm>