<Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

[Pankaj Bansal]

Hello Tejpal,

 

The product fix part looks ok to me.

You are still not following the 80 chars max per line convention in line 44. 

Also, you don't need to print keysCount and KeySetCount if they are equal. Just add this information in Runtime Exception you are throwing when the test fails.

 

Regards,

Pankaj

 

From: Tejpal Rebari 
Sent: Monday, March 9, 2020 5:33 AM
To: Pankaj Bansal <pankaj.b.bansal at oracle.com>; Sergey Bylokhov <sergey.bylokhov at oracle.com>
Cc: swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

 

Hello Pankaj and Sergey,

 

I have updated the keySet() method and test as per your suggestions.

Please take a look.

 

Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/

 

Regards

Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200308/315251a2/attachment.htm>