<Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Tejpal Rebari tejpal.rebari at oracle.com
Mon Mar 9 06:53:40 UTC 2020


Thanks for review Pankaj.

> On 09-Mar-2020, at 11:42 AM, Pankaj Bansal <pankaj.b.bansal at oracle.com> wrote:
> 
> Hello Tejpal,
>  
> The product fix part looks ok to me.
> You are still not following the 80 chars max per line convention in line 44. 
> Also, you don’t need to print keysCount and KeySetCount if they are equal. Just add this information in Runtime Exception you are throwing when the test fails.
>  
> Regards,
> Pankaj

I will fix it during the push.

Regards
Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200309/f4d08c2c/attachment.htm>


More information about the swing-dev mailing list