<Swing Dev> RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions

[psadhukhan-personal]

On Mon, 12 Oct 2020 08:01:43 GMT, Tejpal Rebari <trebari at openjdk.org> wrote:

> Please review the following fix for jdk16.
> 
> Issue : There is a  JToggleButton that will post/take down a JPopupMenu when the button is selected. If the button is
> selected and the menu is not posted the action listener will post the menu. If the button is selected and the menu is
> displayed the action listener will take the menu down. The use case is: 1 - select button 2 - menu posted
> 3 - select button
> 4 - menu taken down
> 
> With MetalLookAndFeel the above use case works fine, but with WindowsLookAndFeel the second button selection does not
> fire the actionPerformed event,  button needs to be selected third time for the menu to be taken down.
> The issue is that the button must be selected twice after the menu is posted to have the actionPerformed event to fire
> when using the Windows look and feel.
> Fix : MouseGrabber is not removed while uninstalling the listeners in the BasicPopupMenuUI.
> By removing the mouseGrabber in the uninstallListeners() methods fixes this issue.
> 
> Added a test to test the same in all the LookAndFeels

Hi Tejpal,
It seems the effect is in WindowsLookAndFeel but you are fixing in Basic L&F. If the cause is in Basic L&F, then it
would have affected other L&F also like Metal,Nimbus, doesn't it? If MouseGrabber not removed is the problem, the I
guess MouseGrabber.uninstall() is not called. This is called in BasicLookAndFeel#uninitialize() and is overridden in
WindowsLookAndFeel. Metal does not override this so maybe that's why the issue is not seen in Metal.  Probably the
right fix is to call this MouseGrabber.uninstall() in Windows:LookAndFeel.uninitialize() same way as is done in
BasicLookAndFeel.uninitialize()

-------------

PR: https://git.openjdk.java.net/jdk/pull/600