<Swing Dev> RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

Sergey Bylokhov serb at openjdk.java.net
Thu Apr 1 17:03:21 UTC 2021


On Thu, 1 Apr 2021 16:14:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> Marked as reviewed by aivanov (Reviewer).

> This might have been overlooked. The overridden method changes the behaviour. I'm for documenting the updated behaviour.

It does not, the spec of the parent is still applicable to this method since the "associated popup menu" is actually a part of the JMenu. And we have other similar methods as well like JTextComponent#setComponentOrientation. 
Note that even JMenu#applyComponentOrientation says nothing about "associated popup menu" but instead uses "getMenuComponents" - this is why that method is overridden.



> It looks as the intentional change in the javadoc tool.

It is still under deiscussion in JDK-8264217

-------------

PR: https://git.openjdk.java.net/jdk/pull/3213


More information about the swing-dev mailing list