<Swing Dev> RFR: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec [v5]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Apr 7 03:35:30 UTC 2021


On Thu, 1 Apr 2021 17:00:15 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Marked as reviewed by aivanov (Reviewer).
>
>> This might have been overlooked. The overridden method changes the behaviour. I'm for documenting the updated behaviour.
> 
> It does not, the spec of the parent is still applicable to this method since the "associated popup menu" is actually a part of the JMenu. And we have other similar methods as well like JTextComponent#setComponentOrientation. 
> Note that even JMenu#applyComponentOrientation says nothing about "associated popup menu" but instead uses "getMenuComponents" - this is why that method is overridden.
> 
> 
> 
>> It looks as the intentional change in the javadoc tool.
> 
> It is still under deiscussion in JDK-8264217

@jonathan-gibbons 
I dont see any update in JDK-8264217. Is this then considered to be a javadoc bug? If yes, can I close this as dup of JDK-8264217?
I see we have 3 options
	1. Close this as dup of javadoc bug JDK-8264217?
	2. Use {@code inheritDoc} to retain the spec of the super class method but 
	   it seems to not showing the spec if there is no change in spec wording compared to super class method. Can it be rectified in javadoc?
    3. Use the spec wording as it is currently which will then be shown in spec as it is different from super class method.

    Please let me know which option to pursue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3213


More information about the swing-dev mailing list