<Swing Dev> RFR: 8264398: BevelBorderUIResource​(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color [v3]

Dmitry Bessonov dbessono at openjdk.java.net
Sat Apr 10 11:26:27 UTC 2021


On Sat, 10 Apr 2021 02:56:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 89:
>> 
>>> 87:      * Creates a bevel border with the specified type, highlight and
>>> 88:      * shadow colors.
>>> 89:      * highlightOuterColor and highlightInnerColor will be derived from
>> 
>> I think we should use just a brief text for "highlightOuterColor"/etc like in the other parts of class "the outer shadow"/"the inner shadow"/"the inner highlight" etc.  Since in this particular case the highlightOuterColor is not a parameter nor a field.
>> And please update the copyright dates.
>
> I guess I have done what is being asked. Are there any other comments? If not, can this PR and CSR be approved please?

So as per the updated version of the specification - what could be checked is that the resulting inner/outer/highlight/shadow colors should be either:
 - equal to the passed
 - ::brighter() than the passed
 - darker() than the passed
 ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3305


More information about the swing-dev mailing list