<Swing Dev> RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

[Prasanta Sadhukhan]

On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly  ie, pressed but not released.
>> 
>> Considering many more tests would have failed if CAPS_LOCK is turned on, I tried to find if some tests uses SHIFT key mistakenly and it seems JRadioButton test has press/release order wrong and it uses SHIFT. Rectified that.
>> 
>> In addition, corrected some known CI issues ie waiting after frame is made visible, made frame to centre. Along with that, also modified testcase to check lowercase string. Since the original JDK-4275046 issue is about newly entered text is made part of cell or not, it does not matter if it's in lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, this test will not be affected.
>> 
>> CI run for several iterations running these 2 tests one after another in all platforms is green.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Testfix for inadvertent CAPS_LOCK enable problem

Since FIRST failure is java/awt/SplashScreen/MultiResolutionSplash/MultiResolutionSplashTest.java
I tried to find tests that uses VK_SHIFT key which are


java/awt/Debug/DumpOnKey/DumpOnKey.java
	java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
	java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
	java/awt/dnd/RecognizedActionTest/RecognizedActionTest.java
	java/awt/event/KeyEvent/8020209/bug8020209.java
	java/awt/event/KeyEvent/ExtendedModifiersTest/ExtendedModifiersTest.java
	java/awt/event/KeyEvent/KeyMaskTest/KeyMaskTest.java
	java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java
	java/awt/event/MouseEvent/MouseButtonsAndKeyMasksTest/MouseButtonsAndKeyMasksTest.java
	java/awt/FileDialog/MacOSGoToFolderCrash.java
	java/awt/Focus/8073453/AWTFocusTransitionTest.java
	java/awt/Focus/8073453/SwingFocusTransitionTest.java
	java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
	java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java
	java/awt/keyboard/AllKeyCode/AllKeyCode.java
	java/awt/List/ActionEventTest/ActionEventTest.java
	java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java
	java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java
	java/awt/Robot/ModifierRobotKey/ModifierRobotEnhancedKeyTest.java
	java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java


and CAPS_LOCK keys


java/awt/keyboard/AllKeyCode/AllKeyCode.java
	java/awt/Toolkit/Headless/HeadlessToolkit.java
	java/awt/Toolkit/LockingKeyStateTest/LockingKeyStateTest.java



I could not find any misuse of VK_SHIFT apart from in 
test/jdk/java/awt/List/ActionEventTest/ActionEventTest.java
test/jdk/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.java
which I rectified. 

For CAPS_LOCK, LockingKeyState was already rectified as I mentioned in previous comment and 
HeadlessToolkit is headless which will not affect headful tests

-------------

PR: https://git.openjdk.java.net/jdk/pull/5079