<Swing Dev> RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

Phil Race prr at openjdk.java.net
Mon Aug 16 21:06:27 UTC 2021


On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly  ie, pressed but not released.
>> 
>> Considering many more tests would have failed if CAPS_LOCK is turned on, I tried to find if some tests uses SHIFT key mistakenly and it seems JRadioButton test has press/release order wrong and it uses SHIFT. Rectified that.
>> 
>> In addition, corrected some known CI issues ie waiting after frame is made visible, made frame to centre. Along with that, also modified testcase to check lowercase string. Since the original JDK-4275046 issue is about newly entered text is made part of cell or not, it does not matter if it's in lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, this test will not be affected.
>> 
>> CI run for several iterations running these 2 tests one after another in all platforms is green.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Testfix for inadvertent CAPS_LOCK enable problem

I think what you need to do is take the list of tests that were run before the FIRST failure - not this one.
Keep them in order - very important
Now find all of them those that use SHIFT (more likey) or CAPS_LOCK
It should be at least easy to get that candidate list

Then work (backwards) through those to see which might have let SHIFT down which may be harder.

One thing I don't know (or understand) is why some other test that presses SHIFT did not release it and solve the problem.

Oh, and finding prior tests which would have failed if SHIFT was down but "pass" might also help the search.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5079


More information about the swing-dev mailing list