<Swing Dev> RFR: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs [v2]

Phil Race prr at openjdk.java.net
Thu Jan 21 16:28:19 UTC 2021


> This removes desktop module usage of the JNF JNI reference convenience APIs
> These are simply a direct conversion
> JNFNewGlobalRef 
> JNFDeleteGlobalRef 
> JNFNewWeakGlobalRef 
> JNFDeleteWeakGlobalRef 
> 
> These two
> JNFJObjectWrapper 
> JNFWeakJObjectWrapper 
> exist to allow clean up of the refs when a Cocoa wrapper object is released.
> However in all cases there are more direct ways to clean it up and in at least one usage
> the existing code directly releases it with the comment that this is more efficient.
> 
> All our automated regression and JCK tests pass with this change.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2133/files
  - new: https://git.openjdk.java.net/jdk/pull/2133/files/61d6476b..6a9e7a0d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2133&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2133&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2133.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2133/head:pull/2133

PR: https://git.openjdk.java.net/jdk/pull/2133


More information about the swing-dev mailing list