<Swing Dev> RFR: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs [v2]

Sergey Bylokhov serb at openjdk.java.net
Fri Jan 22 01:22:10 UTC 2021


On Thu, 21 Jan 2021 16:28:19 GMT, Phil Race <prr at openjdk.org> wrote:

>> This removes desktop module usage of the JNF JNI reference convenience APIs
>> These are simply a direct conversion
>> JNFNewGlobalRef 
>> JNFDeleteGlobalRef 
>> JNFNewWeakGlobalRef 
>> JNFDeleteWeakGlobalRef 
>> 
>> These two
>> JNFJObjectWrapper 
>> JNFWeakJObjectWrapper 
>> exist to allow clean up of the refs when a Cocoa wrapper object is released.
>> However in all cases there are more direct ways to clean it up and in at least one usage
>> the existing code directly releases it with the comment that this is more efficient.
>> 
>> All our automated regression and JCK tests pass with this change.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2133


More information about the swing-dev mailing list