<Swing Dev> RFR: 6251901: BasicTextUI: installDefaults method are contrary to the documentation [v3]

[Alexey Ivanov]

On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> BasicTextUI: installDefaults javadoc specifies only font, foreground and background properties are set  if their current value is either null or a UIResource
>> and other properties are set if the current value is null
>> but in reality all properties such as font, foreground, background, caret color, selection color, selected text color, disabled text color, and border color are set if their current value is either null or a UIResource.
>> Fixed the javadoc to specify the same.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright change

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 306:

> 304:      * Initializes component properties, such as font, foreground,
> 305:      * background, caret color, selection color, selected text color,
> 306:      * disabled text color, border and margin. Each property is set

Suggestion:

     * disabled text color, border, and margin. Each property is set
I suggest keeping the command before “and” as it was before.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2888