<Swing Dev> RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing [v2]

Alexey Ivanov aivanov at openjdk.java.net
Mon Mar 15 10:48:11 UTC 2021


On Mon, 15 Mar 2021 04:17:51 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/JComponent.java line 659:
>> 
>>> 657: 
>>> 658:     /**
>>> 659:      * Resets the UI property to a value from the current look and feel.
>> 
>> Shall it rather use plural?
>> Suggestion:
>> 
>>      * Resets the UI properties to values from the current look and feel.
>> There are usually several properties that get updated, *all the properties* in fact.
>
> I see that all subclass of JComponent implementing updateUI() cites this sentence so changing only here may not be proper unless we change it everywhere, so I guess let it be as it is.

Agreed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2955


More information about the swing-dev mailing list