[threeten-dev] Add support for pattern letters 'e', 'w', 'W' that use locale dependent fields

[Stephen Colebourne]

I'm not sure why "appendWeekBasedField()" is needed. I think it can be inlined.

The instance variables in WeekBasedFieldPrinterParser should be private.

FYI, the test in TCKDateTimeFormatterBuilder at line 711 that you
updated should not be a TCK test, as it evaluates against the
toString() format of the internal printer/parsers, which is not
defined in the spec.

Is there anything stopping the two new tests from being TCK tests?

Otherwsie looks good. I suggest pushing.

Stephen


On 17 December 2012 04:29, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Hi,
>
> Issue 39  DateTimeFormatterBuilder: doesn't accept pattern with "w"
> <https://github.com/ThreeTen/threeten/issues/39>
>
> Should be resolved with this change:
>
>    http://cr.openjdk.java.net/~rriggs/webrev-patterns/
>
> Comments appreciated.