[threeten-dev] Add support for pattern letters 'e', 'w', 'W' that use locale dependent fields

[Roger Riggs]

Hi Stephen,

On 12/17/2012 6:47 AM, Stephen Colebourne wrote:
> I'm not sure why "appendWeekBasedField()" is needed. I think it can be inlined.
ok,  the pattern seemed to be to have an append method (public) but that
can't be supported because there is no way to identify the localized field
in the public API.  So locale based pattern support will be private.
>
> The instance variables in WeekBasedFieldPrinterParser should be private.
ok
>
> FYI, the test in TCKDateTimeFormatterBuilder at line 711 that you
> updated should not be a TCK test, as it evaluates against the
> toString() format of the internal printer/parsers, which is not
> defined in the spec.
Will flag it as implementation for how.
>
> Is there anything stopping the two new tests from being TCK tests?
will move them.  Many tests that use internals will need to be updated
with the move to java.time.
>
> Otherwise looks good. I suggest pushing.
ok, with some updates.

Roger

>
> Stephen
>
>
> On 17 December 2012 04:29, Roger Riggs<Roger.Riggs at oracle.com>  wrote:
>> Hi,
>>
>> Issue 39  DateTimeFormatterBuilder: doesn't accept pattern with "w"
>> <https://github.com/ThreeTen/threeten/issues/39>
>>
>> Should be resolved with this change:
>>
>>     http://cr.openjdk.java.net/~rriggs/webrev-patterns/
>>
>> Comments appreciated.

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment